2 @message |
Performance problem
assert
- ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
- ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
+ /* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
+ 2.6842
+ 2.9444
+ 2.8889
+ 3.0000
+ 2.5500
+ 2.2727
+ 2.6667
+ 3.1579
+ 2.5789
+ 2.8000
+ 2.6667
+ Median value: 2.6842 - GREATER than threshold: 0.8000
+ ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
+ 2.4000
+ 2.4091
+ 2.2857
+ 2.2727
+ 1.6552
+ 2.3182
+ 2.3810
+ 2.3182
+ 2.0870
+ 2.4286
+ 2.3333
+ Median value: 2.3182 - GREATER than threshold: 0.8000
LOG DETAILS:
2024-08-09 16:27:07.212
2024-08-09 16:27:07.219 act = <firebird.qa.plugin.Action object at [hex]>
2024-08-09 16:27:07.233 capsys = <_pytest.capture.CaptureFixture object at [hex]>
2024-08-09 16:27:07.244
2024-08-09 16:27:07.252 @pytest.mark.version('>=3.0.3')
2024-08-09 16:27:07.260 def test_1(act: Action, capsys):
2024-08-09 16:27:07.266 time_data = {}
2024-08-09 16:27:07.272 with act.db.connect() as con:
2024-08-09 16:27:07.278 cur=con.cursor()
2024-08-09 16:27:07.284 cur.execute('select mon$server_pid as p from mon$attachments where mon$attachment_id = current_connection')
2024-08-09 16:27:07.290 fb_pid = int(cur.fetchone()[0])
2024-08-09 16:27:07.295
2024-08-09 16:27:07.300 for i in range(0, N_MEASURES):
2024-08-09 16:27:07.304 fb_info_1 = psutil.Process(fb_pid).cpu_times()
2024-08-09 16:27:07.309 con.execute_immediate(f'alter domain bool_emul drop constraint -- {i}')
2024-08-09 16:27:07.314 fb_info_2 = psutil.Process(fb_pid).cpu_times()
2024-08-09 16:27:07.319 con.commit()
2024-08-09 16:27:07.324 fb_info_3 = psutil.Process(fb_pid).cpu_times()
2024-08-09 16:27:07.329 time_data[ 'del_constraint', i ] = ( max(fb_info_2.user - fb_info_1.user, 0.000001), max(fb_info_3.user - fb_info_2.user, 0.000001) )
2024-08-09 16:27:07.333
2024-08-09 16:27:07.339 con.execute_immediate(f"alter domain bool_emul add check (value in ('t', 'f')) -- {i}")
2024-08-09 16:27:07.344 fb_info_4 = psutil.Process(fb_pid).cpu_times()
2024-08-09 16:27:07.348 con.commit()
2024-08-09 16:27:07.354 fb_info_5 = psutil.Process(fb_pid).cpu_times()
2024-08-09 16:27:07.359 time_data[ 'add_constraint', i ] = ( max(fb_info_4.user - fb_info_3.user, 0.000001), max(fb_info_5.user - fb_info_4.user, 0.000001) )
2024-08-09 16:27:07.365
2024-08-09 16:27:07.371
2024-08-09 16:27:07.378 del_constraint_to_commit_ratios = [ v[0] / v[1] for k,v in time_data.items() if k[0] == 'del_constraint' ]
2024-08-09 16:27:07.385 add_constraint_to_commit_ratios = [ v[0] / v[1] for k,v in time_data.items() if k[0] == 'add_constraint' ]
2024-08-09 16:27:07.391
2024-08-09 16:27:07.397 #for k,v in sorted(time_data.items()):
2024-08-09 16:27:07.403 # print(k,':::',v)
2024-08-09 16:27:07.410 #print(del_constraint_to_commit_ratios)
2024-08-09 16:27:07.416 #print(add_constraint_to_commit_ratios)
2024-08-09 16:27:07.421
2024-08-09 16:27:07.426 del_constr_to_commit_median = median(del_constraint_to_commit_ratios)
2024-08-09 16:27:07.434 add_constr_to_commit_median = median(add_constraint_to_commit_ratios)
2024-08-09 16:27:07.439
2024-08-09 16:27:07.445 msg_del_success = 'ALTER DOMAIN DROP CONSTRAINT performed for acceptable time'
2024-08-09 16:27:07.452 msg_add_success = 'ALTER DOMAIN ADD CONSTRAINT performed for acceptable time'
2024-08-09 16:27:07.459
2024-08-09 16:27:07.465 if del_constr_to_commit_median < DEL_2_COMMIT_MAX_RATIO:
2024-08-09 16:27:07.470 print(msg_del_success)
2024-08-09 16:27:07.476 else:
2024-08-09 16:27:07.483 print('/* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:')
2024-08-09 16:27:07.489 for p in del_constraint_to_commit_ratios:
2024-08-09 16:27:07.495 print('%12.4f' % p)
2024-08-09 16:27:07.510 print('Median value: %12.4f - GREATER than threshold: %12.4f' % (del_constr_to_commit_median,DEL_2_COMMIT_MAX_RATIO))
2024-08-09 16:27:07.517
2024-08-09 16:27:07.524
2024-08-09 16:27:07.530 if add_constr_to_commit_median < ADD_2_COMMIT_MAX_RATIO:
2024-08-09 16:27:07.537 print(msg_add_success)
2024-08-09 16:27:07.542 else:
2024-08-09 16:27:07.546 print('ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:')
2024-08-09 16:27:07.552 for p in add_constraint_to_commit_ratios:
2024-08-09 16:27:07.557 print('%12.4f' % p)
2024-08-09 16:27:07.563 print('Median value: %12.4f - GREATER than threshold: %12.4f' % (add_constr_to_commit_median,ADD_2_COMMIT_MAX_RATIO))
2024-08-09 16:27:07.568
2024-08-09 16:27:07.577 expected_stdout = '''
2024-08-09 16:27:07.587 ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
2024-08-09 16:27:07.596 ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
2024-08-09 16:27:07.603 '''
2024-08-09 16:27:07.609
2024-08-09 16:27:07.616 act.expected_stdout = expected_stdout
2024-08-09 16:27:07.623 act.stdout = capsys.readouterr().out
2024-08-09 16:27:07.629 > assert act.clean_stdout == act.clean_expected_stdout
2024-08-09 16:27:07.635 E assert
2024-08-09 16:27:07.642 E - ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
2024-08-09 16:27:07.649 E - ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
2024-08-09 16:27:07.656 E + /* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
2024-08-09 16:27:07.662 E + 2.6842
2024-08-09 16:27:07.668 E + 2.9444
2024-08-09 16:27:07.674 E + 2.8889
2024-08-09 16:27:07.680 E + 3.0000
2024-08-09 16:27:07.686 E + 2.5500
2024-08-09 16:27:07.696 E + 2.2727
2024-08-09 16:27:07.709 E + 2.6667
2024-08-09 16:27:07.720 E + 3.1579
2024-08-09 16:27:07.729 E + 2.5789
2024-08-09 16:27:07.739 E + 2.8000
2024-08-09 16:27:07.748 E + 2.6667
2024-08-09 16:27:07.755 E + Median value: 2.6842 - GREATER than threshold: 0.8000
2024-08-09 16:27:07.762 E + ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
2024-08-09 16:27:07.768 E + 2.4000
2024-08-09 16:27:07.774 E + 2.4091
2024-08-09 16:27:07.779 E + 2.2857
2024-08-09 16:27:07.785 E + 2.2727
2024-08-09 16:27:07.791 E + 1.6552
2024-08-09 16:27:07.803 E + 2.3182
2024-08-09 16:27:07.811 E + 2.3810
2024-08-09 16:27:07.819 E + 2.3182
2024-08-09 16:27:07.827 E + 2.0870
2024-08-09 16:27:07.833 E + 2.4286
2024-08-09 16:27:07.839 E + 2.3333
2024-08-09 16:27:07.846 E + Median value: 2.3182 - GREATER than threshold: 0.8000
2024-08-09 16:27:07.852
2024-08-09 16:27:07.858 tests/bugs/core_5602_test.py:115: AssertionError
2024-08-09 16:27:07.865 ---------------------------- Captured stdout setup -----------------------------
2024-08-09 16:27:07.872 Restoring db: /var/tmp/qa_2024/test_11115/test.fdb from /opt/distr/venv/firebird-qa/backups/core5602.fbk
|
3 #text |
act = <firebird.qa.plugin.Action pytest object at [hex]>
capsys = <_pytest.capture.CaptureFixture pytest object at [hex]>
@pytest.mark.version('>=3.0.3')
def test_1(act: Action, capsys):
time_data = {}
with act.db.connect() as con:
cur=con.cursor()
cur.execute('select mon$server_pid as p from mon$attachments where mon$attachment_id = current_connection')
fb_pid = int(cur.fetchone()[0])
for i in range(0, N_MEASURES):
fb_info_1 = psutil.Process(fb_pid).cpu_times()
con.execute_immediate(f'alter domain bool_emul drop constraint -- {i}')
fb_info_2 = psutil.Process(fb_pid).cpu_times()
con.commit()
fb_info_3 = psutil.Process(fb_pid).cpu_times()
time_data[ 'del_constraint', i ] = ( max(fb_info_2.user - fb_info_1.user, 0.000001), max(fb_info_3.user - fb_info_2.user, 0.000001) )
con.execute_immediate(f"alter domain bool_emul add check (value in ('t', 'f')) -- {i}")
fb_info_4 = psutil.Process(fb_pid).cpu_times()
con.commit()
fb_info_5 = psutil.Process(fb_pid).cpu_times()
time_data[ 'add_constraint', i ] = ( max(fb_info_4.user - fb_info_3.user, 0.000001), max(fb_info_5.user - fb_info_4.user, 0.000001) )
del_constraint_to_commit_ratios = [ v[0] / v[1] for k,v in time_data.items() if k[0] == 'del_constraint' ]
add_constraint_to_commit_ratios = [ v[0] / v[1] for k,v in time_data.items() if k[0] == 'add_constraint' ]
#for k,v in sorted(time_data.items()):
# print(k,':::',v)
#print(del_constraint_to_commit_ratios)
#print(add_constraint_to_commit_ratios)
del_constr_to_commit_median = median(del_constraint_to_commit_ratios)
add_constr_to_commit_median = median(add_constraint_to_commit_ratios)
msg_del_success = 'ALTER DOMAIN DROP CONSTRAINT performed for acceptable time'
msg_add_success = 'ALTER DOMAIN ADD CONSTRAINT performed for acceptable time'
if del_constr_to_commit_median < DEL_2_COMMIT_MAX_RATIO:
print(msg_del_success)
else:
print('/* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:')
for p in del_constraint_to_commit_ratios:
print('%12.4f' % p)
print('Median value: %12.4f - GREATER than threshold: %12.4f' % (del_constr_to_commit_median,DEL_2_COMMIT_MAX_RATIO))
if add_constr_to_commit_median < ADD_2_COMMIT_MAX_RATIO:
print(msg_add_success)
else:
print('ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:')
for p in add_constraint_to_commit_ratios:
print('%12.4f' % p)
print('Median value: %12.4f - GREATER than threshold: %12.4f' % (add_constr_to_commit_median,ADD_2_COMMIT_MAX_RATIO))
expected_stdout = '''
ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
'''
act.expected_stdout = expected_stdout
act.stdout = capsys.readouterr().out
> assert act.clean_stdout == act.clean_expected_stdout
E assert
E - ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
E - ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
E + /* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
E + 2.6842
E + 2.9444
E + 2.8889
E + 3.0000
E + 2.5500
E + 2.2727
E + 2.6667
E + 3.1579
E + 2.5789
E + 2.8000
E + 2.6667
E + Median value: 2.6842 - GREATER than threshold: 0.8000
E + ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
E + 2.4000
E + 2.4091
E + 2.2857
E + 2.2727
E + 1.6552
E + 2.3182
E + 2.3810
E + 2.3182
E + 2.0870
E + 2.4286
E + 2.3333
E + Median value: 2.3182 - GREATER than threshold: 0.8000
tests/bugs/core_5602_test.py:115: AssertionError
|