2 @message |
Performance problem
assert
- ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
- ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
+ /* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
+ 2.3478
+ 2.0500
+ 2.0455
+ 2.4444
+ 2.9444
+ 2.2222
+ 2.3333
+ 2.3000
+ 2.3158
+ 2.3000
+ 2.2105
+ Median value: 2.3000 - GREATER than threshold: 0.8000
+ ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
+ 1.9231
+ 1.7727
+ 2.1000
+ 1.7083
+ 2.4000
+ 1.5652
+ 1.6522
+ 1.9130
+ 2.0000
+ 1.5185
+ 2.0000
+ Median value: 1.9130 - GREATER than threshold: 0.8000
LOG DETAILS:
2024-05-08 19:34:35.476
2024-05-08 19:34:35.482 act = <firebird.qa.plugin.Action object at [hex]>
2024-05-08 19:34:35.488 capsys = <_pytest.capture.CaptureFixture object at [hex]>
2024-05-08 19:34:35.493
2024-05-08 19:34:35.498 @pytest.mark.version('>=3.0.3')
2024-05-08 19:34:35.503 def test_1(act: Action, capsys):
2024-05-08 19:34:35.508 time_data = {}
2024-05-08 19:34:35.513 with act.db.connect() as con:
2024-05-08 19:34:35.519 cur=con.cursor()
2024-05-08 19:34:35.524 cur.execute('select mon$server_pid as p from mon$attachments where mon$attachment_id = current_connection')
2024-05-08 19:34:35.529 fb_pid = int(cur.fetchone()[0])
2024-05-08 19:34:35.534
2024-05-08 19:34:35.539 for i in range(0, N_MEASURES):
2024-05-08 19:34:35.544 fb_info_1 = psutil.Process(fb_pid).cpu_times()
2024-05-08 19:34:35.549 con.execute_immediate(f'alter domain bool_emul drop constraint -- {i}')
2024-05-08 19:34:35.554 fb_info_2 = psutil.Process(fb_pid).cpu_times()
2024-05-08 19:34:35.568 con.commit()
2024-05-08 19:34:35.575 fb_info_3 = psutil.Process(fb_pid).cpu_times()
2024-05-08 19:34:35.581 time_data[ 'del_constraint', i ] = ( max(fb_info_2.user - fb_info_1.user, 0.000001), max(fb_info_3.user - fb_info_2.user, 0.000001) )
2024-05-08 19:34:35.586
2024-05-08 19:34:35.592 con.execute_immediate(f"alter domain bool_emul add check (value in ('t', 'f')) -- {i}")
2024-05-08 19:34:35.598 fb_info_4 = psutil.Process(fb_pid).cpu_times()
2024-05-08 19:34:35.603 con.commit()
2024-05-08 19:34:35.608 fb_info_5 = psutil.Process(fb_pid).cpu_times()
2024-05-08 19:34:35.613 time_data[ 'add_constraint', i ] = ( max(fb_info_4.user - fb_info_3.user, 0.000001), max(fb_info_5.user - fb_info_4.user, 0.000001) )
2024-05-08 19:34:35.618
2024-05-08 19:34:35.624
2024-05-08 19:34:35.629 del_constraint_to_commit_ratios = [ v[0] / v[1] for k,v in time_data.items() if k[0] == 'del_constraint' ]
2024-05-08 19:34:35.634 add_constraint_to_commit_ratios = [ v[0] / v[1] for k,v in time_data.items() if k[0] == 'add_constraint' ]
2024-05-08 19:34:35.639
2024-05-08 19:34:35.645 #for k,v in sorted(time_data.items()):
2024-05-08 19:34:35.650 # print(k,':::',v)
2024-05-08 19:34:35.655 #print(del_constraint_to_commit_ratios)
2024-05-08 19:34:35.661 #print(add_constraint_to_commit_ratios)
2024-05-08 19:34:35.667
2024-05-08 19:34:35.671 del_constr_to_commit_median = median(del_constraint_to_commit_ratios)
2024-05-08 19:34:35.677 add_constr_to_commit_median = median(add_constraint_to_commit_ratios)
2024-05-08 19:34:35.683
2024-05-08 19:34:35.689 msg_del_success = 'ALTER DOMAIN DROP CONSTRAINT performed for acceptable time'
2024-05-08 19:34:35.694 msg_add_success = 'ALTER DOMAIN ADD CONSTRAINT performed for acceptable time'
2024-05-08 19:34:35.699
2024-05-08 19:34:35.704 if del_constr_to_commit_median < DEL_2_COMMIT_MAX_RATIO:
2024-05-08 19:34:35.709 print(msg_del_success)
2024-05-08 19:34:35.714 else:
2024-05-08 19:34:35.720 print('/* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:')
2024-05-08 19:34:35.725 for p in del_constraint_to_commit_ratios:
2024-05-08 19:34:35.731 print('%12.4f' % p)
2024-05-08 19:34:35.736 print('Median value: %12.4f - GREATER than threshold: %12.4f' % (del_constr_to_commit_median,DEL_2_COMMIT_MAX_RATIO))
2024-05-08 19:34:35.742
2024-05-08 19:34:35.748
2024-05-08 19:34:35.753 if add_constr_to_commit_median < ADD_2_COMMIT_MAX_RATIO:
2024-05-08 19:34:35.758 print(msg_add_success)
2024-05-08 19:34:35.763 else:
2024-05-08 19:34:35.769 print('ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:')
2024-05-08 19:34:35.774 for p in add_constraint_to_commit_ratios:
2024-05-08 19:34:35.778 print('%12.4f' % p)
2024-05-08 19:34:35.783 print('Median value: %12.4f - GREATER than threshold: %12.4f' % (add_constr_to_commit_median,ADD_2_COMMIT_MAX_RATIO))
2024-05-08 19:34:35.788
2024-05-08 19:34:35.793 expected_stdout = '''
2024-05-08 19:34:35.798 ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
2024-05-08 19:34:35.804 ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
2024-05-08 19:34:35.809 '''
2024-05-08 19:34:35.814
2024-05-08 19:34:35.820 act.expected_stdout = expected_stdout
2024-05-08 19:34:35.826 act.stdout = capsys.readouterr().out
2024-05-08 19:34:35.832 > assert act.clean_stdout == act.clean_expected_stdout
2024-05-08 19:34:35.838 E assert
2024-05-08 19:34:35.844 E - ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
2024-05-08 19:34:35.850 E - ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
2024-05-08 19:34:35.856 E + /* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
2024-05-08 19:34:35.861 E + 2.3478
2024-05-08 19:34:35.866 E + 2.0500
2024-05-08 19:34:35.871 E + 2.0455
2024-05-08 19:34:35.877 E + 2.4444
2024-05-08 19:34:35.882 E + 2.9444
2024-05-08 19:34:35.887 E + 2.2222
2024-05-08 19:34:35.892 E + 2.3333
2024-05-08 19:34:35.898 E + 2.3000
2024-05-08 19:34:35.903 E + 2.3158
2024-05-08 19:34:35.908 E + 2.3000
2024-05-08 19:34:35.914 E + 2.2105
2024-05-08 19:34:35.919 E + Median value: 2.3000 - GREATER than threshold: 0.8000
2024-05-08 19:34:35.924 E + ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
2024-05-08 19:34:35.929 E + 1.9231
2024-05-08 19:34:35.935 E + 1.7727
2024-05-08 19:34:35.940 E + 2.1000
2024-05-08 19:34:35.945 E + 1.7083
2024-05-08 19:34:35.952 E + 2.4000
2024-05-08 19:34:35.957 E + 1.5652
2024-05-08 19:34:35.962 E + 1.6522
2024-05-08 19:34:35.969 E + 1.9130
2024-05-08 19:34:35.976 E + 2.0000
2024-05-08 19:34:35.981 E + 1.5185
2024-05-08 19:34:35.987 E + 2.0000
2024-05-08 19:34:35.992 E + Median value: 1.9130 - GREATER than threshold: 0.8000
2024-05-08 19:34:35.997
2024-05-08 19:34:36.003 tests/bugs/core_5602_test.py:115: AssertionError
2024-05-08 19:34:36.008 ---------------------------- Captured stdout setup -----------------------------
2024-05-08 19:34:36.013 Restoring db: /var/tmp/qa_2024/test_11114/test.fdb from /opt/distr/venv/firebird-qa/backups/core5602.fbk
|
3 #text |
act = <firebird.qa.plugin.Action pytest object at [hex]>
capsys = <_pytest.capture.CaptureFixture pytest object at [hex]>
@pytest.mark.version('>=3.0.3')
def test_1(act: Action, capsys):
time_data = {}
with act.db.connect() as con:
cur=con.cursor()
cur.execute('select mon$server_pid as p from mon$attachments where mon$attachment_id = current_connection')
fb_pid = int(cur.fetchone()[0])
for i in range(0, N_MEASURES):
fb_info_1 = psutil.Process(fb_pid).cpu_times()
con.execute_immediate(f'alter domain bool_emul drop constraint -- {i}')
fb_info_2 = psutil.Process(fb_pid).cpu_times()
con.commit()
fb_info_3 = psutil.Process(fb_pid).cpu_times()
time_data[ 'del_constraint', i ] = ( max(fb_info_2.user - fb_info_1.user, 0.000001), max(fb_info_3.user - fb_info_2.user, 0.000001) )
con.execute_immediate(f"alter domain bool_emul add check (value in ('t', 'f')) -- {i}")
fb_info_4 = psutil.Process(fb_pid).cpu_times()
con.commit()
fb_info_5 = psutil.Process(fb_pid).cpu_times()
time_data[ 'add_constraint', i ] = ( max(fb_info_4.user - fb_info_3.user, 0.000001), max(fb_info_5.user - fb_info_4.user, 0.000001) )
del_constraint_to_commit_ratios = [ v[0] / v[1] for k,v in time_data.items() if k[0] == 'del_constraint' ]
add_constraint_to_commit_ratios = [ v[0] / v[1] for k,v in time_data.items() if k[0] == 'add_constraint' ]
#for k,v in sorted(time_data.items()):
# print(k,':::',v)
#print(del_constraint_to_commit_ratios)
#print(add_constraint_to_commit_ratios)
del_constr_to_commit_median = median(del_constraint_to_commit_ratios)
add_constr_to_commit_median = median(add_constraint_to_commit_ratios)
msg_del_success = 'ALTER DOMAIN DROP CONSTRAINT performed for acceptable time'
msg_add_success = 'ALTER DOMAIN ADD CONSTRAINT performed for acceptable time'
if del_constr_to_commit_median < DEL_2_COMMIT_MAX_RATIO:
print(msg_del_success)
else:
print('/* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:')
for p in del_constraint_to_commit_ratios:
print('%12.4f' % p)
print('Median value: %12.4f - GREATER than threshold: %12.4f' % (del_constr_to_commit_median,DEL_2_COMMIT_MAX_RATIO))
if add_constr_to_commit_median < ADD_2_COMMIT_MAX_RATIO:
print(msg_add_success)
else:
print('ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:')
for p in add_constraint_to_commit_ratios:
print('%12.4f' % p)
print('Median value: %12.4f - GREATER than threshold: %12.4f' % (add_constr_to_commit_median,ADD_2_COMMIT_MAX_RATIO))
expected_stdout = '''
ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
'''
act.expected_stdout = expected_stdout
act.stdout = capsys.readouterr().out
> assert act.clean_stdout == act.clean_expected_stdout
E assert
E - ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
E - ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
E + /* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
E + 2.3478
E + 2.0500
E + 2.0455
E + 2.4444
E + 2.9444
E + 2.2222
E + 2.3333
E + 2.3000
E + 2.3158
E + 2.3000
E + 2.2105
E + Median value: 2.3000 - GREATER than threshold: 0.8000
E + ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
E + 1.9231
E + 1.7727
E + 2.1000
E + 1.7083
E + 2.4000
E + 1.5652
E + 1.6522
E + 1.9130
E + 2.0000
E + 1.5185
E + 2.0000
E + Median value: 1.9130 - GREATER than threshold: 0.8000
tests/bugs/core_5602_test.py:115: AssertionError
|