2 @message |
Performance problem
assert
- ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
- ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
+ /* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
+ 2.5789
+ 2.4762
+ 2.6316
+ 3.1111
+ 2.0833
+ 2.2273
+ 2.5500
+ 2.8333
+ 3.0526
+ 2.5000
+ 3.1818
+ Median value: 2.5789 - GREATER than threshold: 0.8000
+ ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
+ 2.3182
+ 2.1304
+ 2.4762
+ 2.1667
+ 1.9286
+ 2.3182
+ 2.2174
+ 2.4000
+ 2.0000
+ 2.2609
+ 2.2174
+ Median value: 2.2174 - GREATER than threshold: 0.8000
LOG DETAILS:
2024-05-08 20:30:26.779
2024-05-08 20:30:26.783 act = <firebird.qa.plugin.Action object at [hex]>
2024-05-08 20:30:26.788 capsys = <_pytest.capture.CaptureFixture object at [hex]>
2024-05-08 20:30:26.792
2024-05-08 20:30:26.797 @pytest.mark.version('>=3.0.3')
2024-05-08 20:30:26.801 def test_1(act: Action, capsys):
2024-05-08 20:30:26.806 time_data = {}
2024-05-08 20:30:26.811 with act.db.connect() as con:
2024-05-08 20:30:26.817 cur=con.cursor()
2024-05-08 20:30:26.823 cur.execute('select mon$server_pid as p from mon$attachments where mon$attachment_id = current_connection')
2024-05-08 20:30:26.829 fb_pid = int(cur.fetchone()[0])
2024-05-08 20:30:26.835
2024-05-08 20:30:26.842 for i in range(0, N_MEASURES):
2024-05-08 20:30:26.848 fb_info_1 = psutil.Process(fb_pid).cpu_times()
2024-05-08 20:30:26.854 con.execute_immediate(f'alter domain bool_emul drop constraint -- {i}')
2024-05-08 20:30:26.860 fb_info_2 = psutil.Process(fb_pid).cpu_times()
2024-05-08 20:30:26.866 con.commit()
2024-05-08 20:30:26.872 fb_info_3 = psutil.Process(fb_pid).cpu_times()
2024-05-08 20:30:26.878 time_data[ 'del_constraint', i ] = ( max(fb_info_2.user - fb_info_1.user, 0.000001), max(fb_info_3.user - fb_info_2.user, 0.000001) )
2024-05-08 20:30:26.884
2024-05-08 20:30:26.890 con.execute_immediate(f"alter domain bool_emul add check (value in ('t', 'f')) -- {i}")
2024-05-08 20:30:26.896 fb_info_4 = psutil.Process(fb_pid).cpu_times()
2024-05-08 20:30:26.902 con.commit()
2024-05-08 20:30:26.908 fb_info_5 = psutil.Process(fb_pid).cpu_times()
2024-05-08 20:30:26.913 time_data[ 'add_constraint', i ] = ( max(fb_info_4.user - fb_info_3.user, 0.000001), max(fb_info_5.user - fb_info_4.user, 0.000001) )
2024-05-08 20:30:26.917
2024-05-08 20:30:26.922
2024-05-08 20:30:26.927 del_constraint_to_commit_ratios = [ v[0] / v[1] for k,v in time_data.items() if k[0] == 'del_constraint' ]
2024-05-08 20:30:26.932 add_constraint_to_commit_ratios = [ v[0] / v[1] for k,v in time_data.items() if k[0] == 'add_constraint' ]
2024-05-08 20:30:26.936
2024-05-08 20:30:26.941 #for k,v in sorted(time_data.items()):
2024-05-08 20:30:26.946 # print(k,':::',v)
2024-05-08 20:30:26.951 #print(del_constraint_to_commit_ratios)
2024-05-08 20:30:26.955 #print(add_constraint_to_commit_ratios)
2024-05-08 20:30:26.960
2024-05-08 20:30:26.965 del_constr_to_commit_median = median(del_constraint_to_commit_ratios)
2024-05-08 20:30:26.969 add_constr_to_commit_median = median(add_constraint_to_commit_ratios)
2024-05-08 20:30:26.974
2024-05-08 20:30:26.979 msg_del_success = 'ALTER DOMAIN DROP CONSTRAINT performed for acceptable time'
2024-05-08 20:30:26.984 msg_add_success = 'ALTER DOMAIN ADD CONSTRAINT performed for acceptable time'
2024-05-08 20:30:26.988
2024-05-08 20:30:26.993 if del_constr_to_commit_median < DEL_2_COMMIT_MAX_RATIO:
2024-05-08 20:30:26.997 print(msg_del_success)
2024-05-08 20:30:27.002 else:
2024-05-08 20:30:27.007 print('/* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:')
2024-05-08 20:30:27.012 for p in del_constraint_to_commit_ratios:
2024-05-08 20:30:27.017 print('%12.4f' % p)
2024-05-08 20:30:27.022 print('Median value: %12.4f - GREATER than threshold: %12.4f' % (del_constr_to_commit_median,DEL_2_COMMIT_MAX_RATIO))
2024-05-08 20:30:27.027
2024-05-08 20:30:27.032
2024-05-08 20:30:27.037 if add_constr_to_commit_median < ADD_2_COMMIT_MAX_RATIO:
2024-05-08 20:30:27.042 print(msg_add_success)
2024-05-08 20:30:27.046 else:
2024-05-08 20:30:27.051 print('ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:')
2024-05-08 20:30:27.056 for p in add_constraint_to_commit_ratios:
2024-05-08 20:30:27.061 print('%12.4f' % p)
2024-05-08 20:30:27.066 print('Median value: %12.4f - GREATER than threshold: %12.4f' % (add_constr_to_commit_median,ADD_2_COMMIT_MAX_RATIO))
2024-05-08 20:30:27.071
2024-05-08 20:30:27.075 expected_stdout = '''
2024-05-08 20:30:27.080 ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
2024-05-08 20:30:27.085 ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
2024-05-08 20:30:27.090 '''
2024-05-08 20:30:27.094
2024-05-08 20:30:27.099 act.expected_stdout = expected_stdout
2024-05-08 20:30:27.104 act.stdout = capsys.readouterr().out
2024-05-08 20:30:27.109 > assert act.clean_stdout == act.clean_expected_stdout
2024-05-08 20:30:27.114 E assert
2024-05-08 20:30:27.118 E - ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
2024-05-08 20:30:27.123 E - ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
2024-05-08 20:30:27.128 E + /* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
2024-05-08 20:30:27.133 E + 2.5789
2024-05-08 20:30:27.138 E + 2.4762
2024-05-08 20:30:27.142 E + 2.6316
2024-05-08 20:30:27.147 E + 3.1111
2024-05-08 20:30:27.152 E + 2.0833
2024-05-08 20:30:27.157 E + 2.2273
2024-05-08 20:30:27.161 E + 2.5500
2024-05-08 20:30:27.166 E + 2.8333
2024-05-08 20:30:27.171 E + 3.0526
2024-05-08 20:30:27.176 E + 2.5000
2024-05-08 20:30:27.180 E + 3.1818
2024-05-08 20:30:27.185 E + Median value: 2.5789 - GREATER than threshold: 0.8000
2024-05-08 20:30:27.190 E + ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
2024-05-08 20:30:27.194 E + 2.3182
2024-05-08 20:30:27.199 E + 2.1304
2024-05-08 20:30:27.204 E + 2.4762
2024-05-08 20:30:27.210 E + 2.1667
2024-05-08 20:30:27.214 E + 1.9286
2024-05-08 20:30:27.219 E + 2.3182
2024-05-08 20:30:27.224 E + 2.2174
2024-05-08 20:30:27.228 E + 2.4000
2024-05-08 20:30:27.233 E + 2.0000
2024-05-08 20:30:27.238 E + 2.2609
2024-05-08 20:30:27.242 E + 2.2174
2024-05-08 20:30:27.247 E + Median value: 2.2174 - GREATER than threshold: 0.8000
2024-05-08 20:30:27.251
2024-05-08 20:30:27.256 tests/bugs/core_5602_test.py:115: AssertionError
2024-05-08 20:30:27.261 ---------------------------- Captured stdout setup -----------------------------
2024-05-08 20:30:27.265 Restoring db: /var/tmp/qa_2024/test_11114/test.fdb from /opt/distr/venv/firebird-qa/backups/core5602.fbk
|
3 #text |
act = <firebird.qa.plugin.Action pytest object at [hex]>
capsys = <_pytest.capture.CaptureFixture pytest object at [hex]>
@pytest.mark.version('>=3.0.3')
def test_1(act: Action, capsys):
time_data = {}
with act.db.connect() as con:
cur=con.cursor()
cur.execute('select mon$server_pid as p from mon$attachments where mon$attachment_id = current_connection')
fb_pid = int(cur.fetchone()[0])
for i in range(0, N_MEASURES):
fb_info_1 = psutil.Process(fb_pid).cpu_times()
con.execute_immediate(f'alter domain bool_emul drop constraint -- {i}')
fb_info_2 = psutil.Process(fb_pid).cpu_times()
con.commit()
fb_info_3 = psutil.Process(fb_pid).cpu_times()
time_data[ 'del_constraint', i ] = ( max(fb_info_2.user - fb_info_1.user, 0.000001), max(fb_info_3.user - fb_info_2.user, 0.000001) )
con.execute_immediate(f"alter domain bool_emul add check (value in ('t', 'f')) -- {i}")
fb_info_4 = psutil.Process(fb_pid).cpu_times()
con.commit()
fb_info_5 = psutil.Process(fb_pid).cpu_times()
time_data[ 'add_constraint', i ] = ( max(fb_info_4.user - fb_info_3.user, 0.000001), max(fb_info_5.user - fb_info_4.user, 0.000001) )
del_constraint_to_commit_ratios = [ v[0] / v[1] for k,v in time_data.items() if k[0] == 'del_constraint' ]
add_constraint_to_commit_ratios = [ v[0] / v[1] for k,v in time_data.items() if k[0] == 'add_constraint' ]
#for k,v in sorted(time_data.items()):
# print(k,':::',v)
#print(del_constraint_to_commit_ratios)
#print(add_constraint_to_commit_ratios)
del_constr_to_commit_median = median(del_constraint_to_commit_ratios)
add_constr_to_commit_median = median(add_constraint_to_commit_ratios)
msg_del_success = 'ALTER DOMAIN DROP CONSTRAINT performed for acceptable time'
msg_add_success = 'ALTER DOMAIN ADD CONSTRAINT performed for acceptable time'
if del_constr_to_commit_median < DEL_2_COMMIT_MAX_RATIO:
print(msg_del_success)
else:
print('/* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:')
for p in del_constraint_to_commit_ratios:
print('%12.4f' % p)
print('Median value: %12.4f - GREATER than threshold: %12.4f' % (del_constr_to_commit_median,DEL_2_COMMIT_MAX_RATIO))
if add_constr_to_commit_median < ADD_2_COMMIT_MAX_RATIO:
print(msg_add_success)
else:
print('ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:')
for p in add_constraint_to_commit_ratios:
print('%12.4f' % p)
print('Median value: %12.4f - GREATER than threshold: %12.4f' % (add_constr_to_commit_median,ADD_2_COMMIT_MAX_RATIO))
expected_stdout = '''
ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
'''
act.expected_stdout = expected_stdout
act.stdout = capsys.readouterr().out
> assert act.clean_stdout == act.clean_expected_stdout
E assert
E - ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
E - ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
E + /* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
E + 2.5789
E + 2.4762
E + 2.6316
E + 3.1111
E + 2.0833
E + 2.2273
E + 2.5500
E + 2.8333
E + 3.0526
E + 2.5000
E + 3.1818
E + Median value: 2.5789 - GREATER than threshold: 0.8000
E + ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
E + 2.3182
E + 2.1304
E + 2.4762
E + 2.1667
E + 1.9286
E + 2.3182
E + 2.2174
E + 2.4000
E + 2.0000
E + 2.2609
E + 2.2174
E + Median value: 2.2174 - GREATER than threshold: 0.8000
tests/bugs/core_5602_test.py:115: AssertionError
|