2 @message |
Performance problem
assert
- ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
- ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
+ /* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
+ 2.7895
+ 1.7727
+ 2.2500
+ 2.4737
+ 2.1429
+ 2.0435
+ 2.5000
+ 2.0909
+ 2.0952
+ 2.0952
+ 2.7500
+ Median value: 2.1429 - GREATER than threshold: 0.8000
+ ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
+ 2.1000
+ 2.0455
+ 1.5600
+ 1.6957
+ 1.6957
+ 2.2609
+ 1.7727
+ 1.9091
+ 2.0000
+ 1.9565
+ 1.7083
+ Median value: 1.9091 - GREATER than threshold: 0.8000
LOG DETAILS:
2024-07-15 13:08:54.213
2024-07-15 13:08:54.220 act = <firebird.qa.plugin.Action object at [hex]>
2024-07-15 13:08:54.227 capsys = <_pytest.capture.CaptureFixture object at [hex]>
2024-07-15 13:08:54.234
2024-07-15 13:08:54.241 @pytest.mark.version('>=3.0.3')
2024-07-15 13:08:54.248 def test_1(act: Action, capsys):
2024-07-15 13:08:54.254 time_data = {}
2024-07-15 13:08:54.261 with act.db.connect() as con:
2024-07-15 13:08:54.268 cur=con.cursor()
2024-07-15 13:08:54.276 cur.execute('select mon$server_pid as p from mon$attachments where mon$attachment_id = current_connection')
2024-07-15 13:08:54.282 fb_pid = int(cur.fetchone()[0])
2024-07-15 13:08:54.287
2024-07-15 13:08:54.293 for i in range(0, N_MEASURES):
2024-07-15 13:08:54.298 fb_info_1 = psutil.Process(fb_pid).cpu_times()
2024-07-15 13:08:54.305 con.execute_immediate(f'alter domain bool_emul drop constraint -- {i}')
2024-07-15 13:08:54.311 fb_info_2 = psutil.Process(fb_pid).cpu_times()
2024-07-15 13:08:54.317 con.commit()
2024-07-15 13:08:54.329 fb_info_3 = psutil.Process(fb_pid).cpu_times()
2024-07-15 13:08:54.342 time_data[ 'del_constraint', i ] = ( max(fb_info_2.user - fb_info_1.user, 0.000001), max(fb_info_3.user - fb_info_2.user, 0.000001) )
2024-07-15 13:08:54.351
2024-07-15 13:08:54.358 con.execute_immediate(f"alter domain bool_emul add check (value in ('t', 'f')) -- {i}")
2024-07-15 13:08:54.364 fb_info_4 = psutil.Process(fb_pid).cpu_times()
2024-07-15 13:08:54.369 con.commit()
2024-07-15 13:08:54.375 fb_info_5 = psutil.Process(fb_pid).cpu_times()
2024-07-15 13:08:54.380 time_data[ 'add_constraint', i ] = ( max(fb_info_4.user - fb_info_3.user, 0.000001), max(fb_info_5.user - fb_info_4.user, 0.000001) )
2024-07-15 13:08:54.385
2024-07-15 13:08:54.389
2024-07-15 13:08:54.394 del_constraint_to_commit_ratios = [ v[0] / v[1] for k,v in time_data.items() if k[0] == 'del_constraint' ]
2024-07-15 13:08:54.400 add_constraint_to_commit_ratios = [ v[0] / v[1] for k,v in time_data.items() if k[0] == 'add_constraint' ]
2024-07-15 13:08:54.405
2024-07-15 13:08:54.410 #for k,v in sorted(time_data.items()):
2024-07-15 13:08:54.415 # print(k,':::',v)
2024-07-15 13:08:54.420 #print(del_constraint_to_commit_ratios)
2024-07-15 13:08:54.426 #print(add_constraint_to_commit_ratios)
2024-07-15 13:08:54.431
2024-07-15 13:08:54.437 del_constr_to_commit_median = median(del_constraint_to_commit_ratios)
2024-07-15 13:08:54.449 add_constr_to_commit_median = median(add_constraint_to_commit_ratios)
2024-07-15 13:08:54.457
2024-07-15 13:08:54.465 msg_del_success = 'ALTER DOMAIN DROP CONSTRAINT performed for acceptable time'
2024-07-15 13:08:54.472 msg_add_success = 'ALTER DOMAIN ADD CONSTRAINT performed for acceptable time'
2024-07-15 13:08:54.478
2024-07-15 13:08:54.485 if del_constr_to_commit_median < DEL_2_COMMIT_MAX_RATIO:
2024-07-15 13:08:54.495 print(msg_del_success)
2024-07-15 13:08:54.501 else:
2024-07-15 13:08:54.508 print('/* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:')
2024-07-15 13:08:54.514 for p in del_constraint_to_commit_ratios:
2024-07-15 13:08:54.520 print('%12.4f' % p)
2024-07-15 13:08:54.528 print('Median value: %12.4f - GREATER than threshold: %12.4f' % (del_constr_to_commit_median,DEL_2_COMMIT_MAX_RATIO))
2024-07-15 13:08:54.533
2024-07-15 13:08:54.539
2024-07-15 13:08:54.545 if add_constr_to_commit_median < ADD_2_COMMIT_MAX_RATIO:
2024-07-15 13:08:54.550 print(msg_add_success)
2024-07-15 13:08:54.556 else:
2024-07-15 13:08:54.562 print('ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:')
2024-07-15 13:08:54.568 for p in add_constraint_to_commit_ratios:
2024-07-15 13:08:54.574 print('%12.4f' % p)
2024-07-15 13:08:54.581 print('Median value: %12.4f - GREATER than threshold: %12.4f' % (add_constr_to_commit_median,ADD_2_COMMIT_MAX_RATIO))
2024-07-15 13:08:54.587
2024-07-15 13:08:54.593 expected_stdout = '''
2024-07-15 13:08:54.599 ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
2024-07-15 13:08:54.610 ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
2024-07-15 13:08:54.616 '''
2024-07-15 13:08:54.622
2024-07-15 13:08:54.628 act.expected_stdout = expected_stdout
2024-07-15 13:08:54.634 act.stdout = capsys.readouterr().out
2024-07-15 13:08:54.644 > assert act.clean_stdout == act.clean_expected_stdout
2024-07-15 13:08:54.654 E assert
2024-07-15 13:08:54.663 E - ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
2024-07-15 13:08:54.670 E - ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
2024-07-15 13:08:54.677 E + /* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
2024-07-15 13:08:54.682 E + 2.7895
2024-07-15 13:08:54.687 E + 1.7727
2024-07-15 13:08:54.692 E + 2.2500
2024-07-15 13:08:54.696 E + 2.4737
2024-07-15 13:08:54.701 E + 2.1429
2024-07-15 13:08:54.708 E + 2.0435
2024-07-15 13:08:54.714 E + 2.5000
2024-07-15 13:08:54.721 E + 2.0909
2024-07-15 13:08:54.727 E + 2.0952
2024-07-15 13:08:54.732 E + 2.0952
2024-07-15 13:08:54.742 E + 2.7500
2024-07-15 13:08:54.749 E + Median value: 2.1429 - GREATER than threshold: 0.8000
2024-07-15 13:08:54.756 E + ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
2024-07-15 13:08:54.761 E + 2.1000
2024-07-15 13:08:54.767 E + 2.0455
2024-07-15 13:08:54.773 E + 1.5600
2024-07-15 13:08:54.783 E + 1.6957
2024-07-15 13:08:54.792 E + 1.6957
2024-07-15 13:08:54.800 E + 2.2609
2024-07-15 13:08:54.807 E + 1.7727
2024-07-15 13:08:54.814 E + 1.9091
2024-07-15 13:08:54.820 E + 2.0000
2024-07-15 13:08:54.826 E + 1.9565
2024-07-15 13:08:54.831 E + 1.7083
2024-07-15 13:08:54.837 E + Median value: 1.9091 - GREATER than threshold: 0.8000
2024-07-15 13:08:54.843
2024-07-15 13:08:54.849 tests/bugs/core_5602_test.py:115: AssertionError
2024-07-15 13:08:54.856 ---------------------------- Captured stdout setup -----------------------------
2024-07-15 13:08:54.862 Restoring db: /var/tmp/qa_2024/test_11115/test.fdb from /opt/distr/venv/firebird-qa/backups/core5602.fbk
|
3 #text |
act = <firebird.qa.plugin.Action pytest object at [hex]>
capsys = <_pytest.capture.CaptureFixture pytest object at [hex]>
@pytest.mark.version('>=3.0.3')
def test_1(act: Action, capsys):
time_data = {}
with act.db.connect() as con:
cur=con.cursor()
cur.execute('select mon$server_pid as p from mon$attachments where mon$attachment_id = current_connection')
fb_pid = int(cur.fetchone()[0])
for i in range(0, N_MEASURES):
fb_info_1 = psutil.Process(fb_pid).cpu_times()
con.execute_immediate(f'alter domain bool_emul drop constraint -- {i}')
fb_info_2 = psutil.Process(fb_pid).cpu_times()
con.commit()
fb_info_3 = psutil.Process(fb_pid).cpu_times()
time_data[ 'del_constraint', i ] = ( max(fb_info_2.user - fb_info_1.user, 0.000001), max(fb_info_3.user - fb_info_2.user, 0.000001) )
con.execute_immediate(f"alter domain bool_emul add check (value in ('t', 'f')) -- {i}")
fb_info_4 = psutil.Process(fb_pid).cpu_times()
con.commit()
fb_info_5 = psutil.Process(fb_pid).cpu_times()
time_data[ 'add_constraint', i ] = ( max(fb_info_4.user - fb_info_3.user, 0.000001), max(fb_info_5.user - fb_info_4.user, 0.000001) )
del_constraint_to_commit_ratios = [ v[0] / v[1] for k,v in time_data.items() if k[0] == 'del_constraint' ]
add_constraint_to_commit_ratios = [ v[0] / v[1] for k,v in time_data.items() if k[0] == 'add_constraint' ]
#for k,v in sorted(time_data.items()):
# print(k,':::',v)
#print(del_constraint_to_commit_ratios)
#print(add_constraint_to_commit_ratios)
del_constr_to_commit_median = median(del_constraint_to_commit_ratios)
add_constr_to_commit_median = median(add_constraint_to_commit_ratios)
msg_del_success = 'ALTER DOMAIN DROP CONSTRAINT performed for acceptable time'
msg_add_success = 'ALTER DOMAIN ADD CONSTRAINT performed for acceptable time'
if del_constr_to_commit_median < DEL_2_COMMIT_MAX_RATIO:
print(msg_del_success)
else:
print('/* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:')
for p in del_constraint_to_commit_ratios:
print('%12.4f' % p)
print('Median value: %12.4f - GREATER than threshold: %12.4f' % (del_constr_to_commit_median,DEL_2_COMMIT_MAX_RATIO))
if add_constr_to_commit_median < ADD_2_COMMIT_MAX_RATIO:
print(msg_add_success)
else:
print('ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:')
for p in add_constraint_to_commit_ratios:
print('%12.4f' % p)
print('Median value: %12.4f - GREATER than threshold: %12.4f' % (add_constr_to_commit_median,ADD_2_COMMIT_MAX_RATIO))
expected_stdout = '''
ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
'''
act.expected_stdout = expected_stdout
act.stdout = capsys.readouterr().out
> assert act.clean_stdout == act.clean_expected_stdout
E assert
E - ALTER DOMAIN DROP CONSTRAINT performed for acceptable time
E - ALTER DOMAIN ADD CONSTRAINT performed for acceptable time
E + /* perf_issue_tag */ ALTER DOMAIN DROP CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
E + 2.7895
E + 1.7727
E + 2.2500
E + 2.4737
E + 2.1429
E + 2.0435
E + 2.5000
E + 2.0909
E + 2.0952
E + 2.0952
E + 2.7500
E + Median value: 2.1429 - GREATER than threshold: 0.8000
E + ALTER DOMAIN ADD CONSTRAINT perfomed too slow. Ratios of DML to COMMIT time:
E + 2.1000
E + 2.0455
E + 1.5600
E + 1.6957
E + 1.6957
E + 2.2609
E + 1.7727
E + 1.9091
E + 2.0000
E + 1.9565
E + 1.7083
E + Median value: 1.9091 - GREATER than threshold: 0.8000
tests/bugs/core_5602_test.py:115: AssertionError
|